combobox: Stop using GtkBox's pack-type property
authorTimm Bäder <mail@baedert.org>
Wed, 26 Dec 2018 07:34:47 +0000 (08:34 +0100)
committerMatthias Clasen <mclasen@redhat.com>
Thu, 24 Jan 2019 00:30:46 +0000 (19:30 -0500)
Reorder the child widgets accordingly instead.

gtk/gtkcombobox.c
gtk/ui/gtkcombobox.ui

index 153cdd4c5beb381db5f5cb9105e235d06a507522..8adddcfe2f6ff70e5a82d0070da1c4717cf8403e 100644 (file)
@@ -1158,6 +1158,7 @@ gtk_combo_box_create_child (GtkComboBox *combo_box)
       gtk_cell_view_set_model (GTK_CELL_VIEW (priv->cell_view), priv->model);
       gtk_container_add (GTK_CONTAINER (gtk_widget_get_parent (priv->arrow)),
                          priv->cell_view);
+      gtk_box_reorder_child (GTK_BOX (gtk_widget_get_parent (priv->arrow)), priv->cell_view, 0);
       _gtk_bin_set_child (GTK_BIN (combo_box), priv->cell_view);
     }
 }
@@ -1193,6 +1194,7 @@ gtk_combo_box_add (GtkContainer *container,
 
   gtk_widget_set_hexpand (widget, TRUE);
   gtk_container_add (GTK_CONTAINER (priv->box), widget);
+  gtk_box_reorder_child (GTK_BOX (priv->box), widget, 0);
   _gtk_bin_set_child (GTK_BIN (container), widget);
 
   if (priv->has_entry)
index cf6a81fd51d8e59815f931b8ca7ef777ad19d58d..533a799c887dea620efd570636af0f3c9a686823 100644 (file)
                   <object class="GtkIcon" id="arrow">
                     <property name="css-name">arrow</property>
                   </object>
-                  <packing>
-                    <property name="pack-type">end</property>
-                  </packing>
                 </child>
               </object>
             </child>
           </object>
-          <packing>
-            <property name="pack-type">end</property>
-          </packing>
         </child>
       </object>
     </child>